kbendick commented on code in PR #4949: URL: https://github.com/apache/iceberg/pull/4949#discussion_r895073343
########## .github/workflows/stale.yml: ########## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Close Stale Issues" +on: + schedule: + - cron: '0 0 * * *' + +permissions: + # All other permissions are set to none + issues: write + +jobs: + stale: + runs-on: ubuntu-20.04 + steps: + - uses: actions/stale@v4 + with: + stale-issue-label: 'stale' + exempt-issue-labels: 'not-stale' Review Comment: Yeah. I agree with Ryan’s assessment. Simply commenting is fine imo. And I think personally that “awaiting-response”, unless automated to be added / removed appropriately, could cause a bit more confusion about which issues should be looked at or not (if reviewing issues and needing to be conscious of time taken on them). Whereas “stale” is clear that it’s been untouched for basically half a year (presently 180 days). That’s sufficient time to be able to not need to assess it further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
