rdblue commented on code in PR #5008: URL: https://github.com/apache/iceberg/pull/5008#discussion_r895226294
########## python/src/iceberg/expressions/base.py: ########## @@ -88,7 +89,7 @@ def negate(self) -> "Operation": } -class Literal(Generic[T], ABC): +class Literal(Generic[T], metaclass=ABCMeta): Review Comment: Why do we want the reader to know that this is changing a metaclass and not just inheriting from ABC? It seems like bringing a metaclass into the code is more clear about what's happening, but introduces a distinction that people (like me) may not understand or need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
