findepi commented on code in PR #4741:
URL: https://github.com/apache/iceberg/pull/4741#discussion_r895462757


##########
api/src/main/java/org/apache/iceberg/Transaction.java:
##########
@@ -137,6 +137,14 @@ default AppendFiles newFastAppend() {
    */
   DeleteFiles newDelete();
 
+  /**
+   * Create a new {@link UpdateTableStatistics update table statistics API} to 
add or remove statistics
+   * files in this table.
+   *
+   * @return a new {@link UpdateTableStatistics}
+   */
+  UpdateTableStatistics newUpdateTableStatistics();

Review Comment:
   I guess i named this after newReplacePartitions or newOverwrite ("replace" 
and "overwrite" are also verbs).
   Sure, will remove "new" here.
   
   > Can you add the API to `Table` and `Transaction` in a separate PR?
   
   Sure.
   Should come together with or separate from BaseTransaction changes?
   Should come together with or separate from BaseSnapshot changes?
   Should come together with or separate from remove_orphan_files changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to