rdblue commented on code in PR #4920:
URL: https://github.com/apache/iceberg/pull/4920#discussion_r896233778
##########
python/src/iceberg/utils/datetime.py:
##########
@@ -36,6 +39,15 @@ def micros_to_days(timestamp: int) -> int:
return (datetime.fromtimestamp(timestamp / 1_000_000) -
EPOCH_TIMESTAMP).days
+def micros_to_time(micros: int) -> time:
Review Comment:
Jun just added `time_from_micros` below that is basically the same thing
(though I like this version better because it uses `divmod`. Can you replace
the use of `time_from_micros` with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
