nastra commented on code in PR #5033:
URL: https://github.com/apache/iceberg/pull/5033#discussion_r896802584
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -187,7 +185,16 @@ public List<TableIdentifier> listTables(Namespace
namespace) {
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
- return client.dropTable(identifier, purge);
+ TableReference tableReference = parseTableReference(identifier);
+ TableIdentifier tableIdentifier;
+ if (tableReference.hasReference()) {
+ tableIdentifier = TableIdentifier.of(identifier.namespace(),
tableReference.getName());
+ } else {
+ tableIdentifier = identifier;
+ }
+
+ NessieIcebergClient newClient =
this.client.withReference(tableReference.getReference(),
tableReference.getHash());
Review Comment:
nit: maybe inline this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
