Fokko commented on code in PR #5011: URL: https://github.com/apache/iceberg/pull/5011#discussion_r897323229
########## python/src/iceberg/utils/iceberg_base_model.py: ########## @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from pydantic import BaseModel + + +class IcebergBaseModel(BaseModel): + class Config: + allow_population_by_field_name = True + + def dict(self, exclude_none=True, **kwargs): + return super().dict(exclude_none=exclude_none, **kwargs) + + def json(self, exclude_none=True, by_alias=True, **kwargs): + return super().json(exclude_none=exclude_none, by_alias=True, **kwargs) Review Comment: In the superclass, the `by_alias` is set to False by default. But for Iceberg it is better to set this to `True` all the time because we rely on aliases when we convert JSON we always want to use the aliases (`schema-id` instead of `schema_id`, since `-` is an operator in Python). The same goes for excluding non-values in the case of the doc element of the NestedField that we don't want to include if it is `None`. By overriding this function, we set these values by default to True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
