pvary commented on code in PR #5036:
URL: https://github.com/apache/iceberg/pull/5036#discussion_r898165162
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -229,7 +241,8 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
tableLevelMutex.lock();
try {
lockId = Optional.of(acquireLock());
- // TODO add lock heart beating for cases where default lock timeout is
too low.
+ hiveLockHeartbeat = new HiveLockHeartbeat(metaClients, lockId.get(),
lockCheckMaxWaitTime);
Review Comment:
This is how Hive schedules the heartbeat:
```
HiveConf.getTimeVar(conf, HiveConf.ConfVars.HIVE_TXN_TIMEOUT,
TimeUnit.MILLISECONDS) / 2;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
