rdblue commented on code in PR #4537: URL: https://github.com/apache/iceberg/pull/4537#discussion_r898264496
########## core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java: ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.puffin; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; +import java.util.EnumSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.Metrics; +import org.apache.iceberg.io.FileAppender; +import org.apache.iceberg.io.IOUtil; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.io.PositionOutputStream; +import org.apache.iceberg.puffin.PuffinFormat.Flag; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +public class PuffinWriter implements FileAppender<Blob> { + // Must not be modified + private static final byte[] MAGIC = PuffinFormat.getMagic(); + + private final PositionOutputStream outputStream; + private final Map<String, String> properties; + private final PuffinCompressionCodec footerCompression; + private final PuffinCompressionCodec defaultBlobCompression; + + private final List<BlobMetadata> writtenBlobsMetadata = Lists.newArrayList(); + private boolean headerWritten; + private boolean finished; + private Optional<Integer> footerSize = Optional.empty(); + private Optional<Long> fileSize = Optional.empty(); + + PuffinWriter( + OutputFile outputFile, Map<String, String> properties, boolean compressFooter, + PuffinCompressionCodec defaultBlobCompression) { + Preconditions.checkNotNull(outputFile, "outputFile is null"); + Preconditions.checkNotNull(properties, "properties is null"); + Preconditions.checkNotNull(defaultBlobCompression, "defaultBlobCompression is null"); + this.outputStream = outputFile.create(); + this.properties = ImmutableMap.copyOf(properties); + this.footerCompression = compressFooter ? PuffinFormat.FOOTER_COMPRESSION_CODEC : PuffinCompressionCodec.NONE; + this.defaultBlobCompression = defaultBlobCompression; + } + + @Override + public void add(Blob blob) { + Preconditions.checkNotNull(blob, "blob is null"); + checkNotFinished(); + try { + writeHeaderIfNeeded(); + long fileOffset = outputStream.getPos(); + PuffinCompressionCodec codec = MoreObjects.firstNonNull(blob.requestedCompression(), defaultBlobCompression); + ByteBuffer rawData = PuffinFormat.compress(codec, blob.blobData()); + int length = rawData.remaining(); + writeFully(rawData); + writtenBlobsMetadata.add(new BlobMetadata(blob.type(), blob.inputFields(), fileOffset, length, + codec.codecName(), blob.properties())); + } catch (IOException e) { + throw new UncheckedIOException(e); + } + } + + @Override + public Metrics metrics() { + return new Metrics(); + } + + @Override + public long length() { + return fileSize(); + } + + @Override + public void close() throws IOException { + if (!finished) { + finish(); + } + + outputStream.close(); + } + + private void writeHeaderIfNeeded() throws IOException { + if (headerWritten) { + return; + } + + this.outputStream.write(MAGIC); + this.headerWritten = true; + } + + public void finish() throws IOException { + checkNotFinished(); + writeHeaderIfNeeded(); + Preconditions.checkState(!footerSize.isPresent(), "footerSize already set"); + long footerOffset = outputStream.getPos(); + writeFooter(); + this.footerSize = Optional.of(Math.toIntExact(outputStream.getPos() - footerOffset)); + this.fileSize = Optional.of(outputStream.getPos()); + this.finished = true; + } + + private void writeFooter() throws IOException { + FileMetadata fileMetadata = new FileMetadata(writtenBlobsMetadata, properties); + ByteBuffer footerJson = ByteBuffer.wrap( + FileMetadataParser.toJson(fileMetadata, false).getBytes(StandardCharsets.UTF_8)); + ByteBuffer footerPayload = PuffinFormat.compress(footerCompression, footerJson); + outputStream.write(MAGIC); + int footerPayloadLength = footerPayload.remaining(); + writeFully(footerPayload); Review Comment: Minor: why not call `IOUtil.writeFully(outputStream, footerPayload)` directly rather than having a private `writeFully` method that just adds the output stream? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
