Fokko commented on code in PR #5011:
URL: https://github.com/apache/iceberg/pull/5011#discussion_r899524711
##########
python/src/iceberg/schema.py:
##########
@@ -343,23 +339,23 @@ def _(obj: StructType, visitor: SchemaVisitor[T]) -> T:
def _(obj: ListType, visitor: SchemaVisitor[T]) -> T:
"""Visit a ListType with a concrete SchemaVisitor"""
- visitor.before_list_element(obj.element)
- result = visit(obj.element.field_type, visitor)
- visitor.after_list_element(obj.element)
+ visitor.before_list_element(obj.element_field)
+ result = visit(obj.element_type, visitor)
+ visitor.after_list_element(obj.element_field)
return visitor.list(obj, result)
@visit.register(MapType)
def _(obj: MapType, visitor: SchemaVisitor[T]) -> T:
"""Visit a MapType with a concrete SchemaVisitor"""
- visitor.before_map_key(obj.key)
- key_result = visit(obj.key.field_type, visitor)
- visitor.after_map_key(obj.key)
+ visitor.before_map_key(obj.key_field)
Review Comment:
We have to change these since we call them by the dataclass alias, but with
Pydantic you need to call them by the variable name, which I like since it is
more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
