singhpk234 opened a new pull request, #5075: URL: https://github.com/apache/iceberg/pull/5075
### About the change : Presently when doing schema conversion we were setting `metadata` for all the the columns, but we should add `____metadata_col` in metadata column which can be used by spark to check if the column is `metadata` col and drop it if required like, here : https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala#L221-L225 Note : `MetadataAttribute` extractor uses the above key in attribute meta data to find if the attribute is metadata attribute or not. This PR includes : (i) Fix for above (ii) Fix an existing minor typo in `TestSparkSchemaUtil` ---- ### Testing Done Added an UT for the same. cc @rdblue @aokolnychyi @jackye1995 @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
