aokolnychyi commented on code in PR #5077:
URL: https://github.com/apache/iceberg/pull/5077#discussion_r900532296
##########
core/src/main/java/org/apache/iceberg/BaseFileScanTask.java:
##########
@@ -217,6 +218,18 @@ public Iterable<FileScanTask> split(long splitSize) {
throw new UnsupportedOperationException("Cannot split a task which is
already split");
}
+ @Override
+ public boolean isAdjacent(FileScanTask other) {
+ return file().equals(other.file()) && offset + len == other.start();
Review Comment:
I copied this logic from an existing place but we have to remember that
files will be equal only if references are equal, which I think is true here.
Our data and delete file implementations don't override equals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
