[GitHub] [iceberg] stevenzwu commented on a diff in pull request #4943: Flink: add an option to set monitoring snapshot number

[GitBox]

stevenzwu commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r900697081


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -139,7 +143,24 @@ public void run(SourceContext<FlinkInputSplit> ctx) throws 
Exception {
     }
   }
 
-  private void monitorAndForwardSplits() {
+  private long maxReachableSnapshotId(long lastConsumedSnapshotId, long 
latestSnapshotId, int maxSnapshotCount) {
+    List<Long> snapshotIds = SnapshotUtil.snapshotIdsBetween(table, 
lastConsumedSnapshotId, latestSnapshotId);
+

Review Comment:
   nit: we add empty line after control block (not before)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org