amogh-jahagirdar commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r902380766
##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -60,4 +60,9 @@
* @return this for method chaining
*/
ThisT scanManifestsWith(ExecutorService executorService);
+
+ /**
+ * Perform operations a particular branch
Review Comment:
@namrathamyske Each child of SnapshotProducer can implement their own
validation logic
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/SnapshotProducer.java#L156
This gets called when trying to apply the operation as part of transaction
conflict detection. For example rewriting data files needs to validate that
there are no new row level deletes for data files which were replaced:
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java#L108
We should define the behavior of validation in the context of branching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
