ajantha-bhat commented on code in PR #4946:
URL: https://github.com/apache/iceberg/pull/4946#discussion_r902656756
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##########
@@ -331,9 +331,21 @@ private String newTableMetadataFilePath(TableMetadata
meta, int newVersion) {
return metadataFileLocation(meta, String.format("%05d-%s%s", newVersion,
UUID.randomUUID(), fileExtension));
}
+ /**
+ * Parse the version from table metadata file name.
+ *
+ * @param metadataLocation table metadata file location
+ * @return version of the table metadata file in success case and
+ * -1 if the version is not parsable (as a sign that the metadata is not
part of this catalog)
+ */
private static int parseVersion(String metadataLocation) {
int versionStart = metadataLocation.lastIndexOf('/') + 1; // if '/' isn't
found, this will be 0
int versionEnd = metadataLocation.indexOf('-', versionStart);
+ if (versionEnd < 0) {
+ LOG.warn("Found filesystem table's metadata : {}", metadataLocation);
Review Comment:
@pvary : As there was no response from @rdblue, I went ahead with your
suggestion and modified the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
