RussellSpitzer commented on code in PR #4812:
URL: https://github.com/apache/iceberg/pull/4812#discussion_r903019191
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -167,6 +181,70 @@ public StructLikeSet rowSet(String name, Types.StructType
projection, String...
return set;
}
+ private StructLikeSet actualPositionDeleteRowSet(String tableName, Table
table) {
+ return actualPositionDeleteRowSet(tableName, table, null, null);
+ }
+
+ private StructLikeSet actualPositionDeleteRowSet(String tableName, Table
table, String filter) {
+ return actualPositionDeleteRowSet(tableName, table, filter, null);
+ }
+
+ private StructLikeSet actualPositionDeleteRowSet(String tableName,
+ Table table,
+ Types.StructType
selectSchema) {
+ return actualPositionDeleteRowSet(tableName, table, null, selectSchema);
+ }
+
+ private StructLikeSet actualPositionDeleteRowSet(String tableName,
+ Table table,
+ String filter,
+ Types.StructType
selectSchema) {
+ Dataset<Row> df = spark.read()
+ .format("iceberg")
+ .load("default." + tableName + ".position_deletes");
+ if (selectSchema != null) {
+ df = df.select(
+ selectSchema.fields().stream().map(
Review Comment:
looks like odd formatting here? maybe put the whole map on the following
line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
