szehon-ho commented on PR #5057: URL: https://github.com/apache/iceberg/pull/5057#issuecomment-1163781495
Sounds good, sorry i am pretty bad at regex, what do you mean: > Used [^;]* instead of .*, because this is a multiline search and the dotall regex param (enabled by matchAcrossLines config) is aggressive and this is the best way to break its search. > It can be removed and the "\s+" can be enough The [^;]* can be removed? The purpose now is to not match %d in the Precondition.checkArgument()'s first argument (or is it for something else)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
