kbendick commented on code in PR #4596:
URL: https://github.com/apache/iceberg/pull/4596#discussion_r904505957
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -65,10 +67,10 @@ private ParallelIterator(Iterable<? extends Iterable<T>>
iterables,
try (Closeable ignored = (iterable instanceof Closeable) ?
(Closeable) iterable : () -> { }) {
for (T item : iterable) {
- queue.add(item);
+ queue.put(item);
}
- } catch (IOException e) {
- throw new RuntimeIOException(e, "Failed to close iterable");
+ } catch (IOException | InterruptedException e) {
+ throw new RuntimeException("Failed to close iterable", e);
Review Comment:
+1 to not using Thread.sleep() anywhere if at all possible. It’s bad for
system performance and generally causes instability at any scale.
@lirui-apache’s result confirm what I’ve expected / known.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
