yittg commented on code in PR #5109:
URL: https://github.com/apache/iceberg/pull/5109#discussion_r904528749
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##########
@@ -482,8 +484,10 @@ protected void addElement(ReusableArrayData reused, E
element) {
@Override
protected ArrayData buildList(ReusableArrayData list) {
- list.setNumElements(writePos);
- return list;
+ // Since ReusableArrayData is not accepted by Flink, use
GenericArrayData temporarily to walk around it.
Review Comment:
I looked into the Flink for why map data works but array data not with
similar implementation, found that the MapDataSerializer#toBinaryMap always
contains copy semantics implicitly but not for
ArrayDataSerializer#toBinaryArray.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
