kbendick opened a new pull request, #5118: URL: https://github.com/apache/iceberg/pull/5118
This PR adds serde tests for `LoadTableResponse` for both V1 and V2. Presently, this PR makes a number of things `public` which were previously package-private, and that I would like to keep package-private. So I'm opening this as draft to get feedback on ways to possibly do that and which ones do we care very much about opening up further in terms of public vs package-private (e.g. I think the BaseSnapshot constructors should remain package-private, but some of the named `Snapshot` constants are probably ok to make public). We can possibly access the protected constructors via test utilities that expose the necessary functions in code that lives in `test` only (like we did for testing some parts of `CachingCatalog`). Or possibly some reflection based accession would be sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
