huaxingao commented on code in PR #5113:
URL: https://github.com/apache/iceberg/pull/5113#discussion_r905766490
##########
api/src/test/java/org/apache/iceberg/expressions/TestPredicateBinding.java:
##########
@@ -605,4 +605,188 @@ public void
testNotInPredicateBindingConversionToExpression() {
Expression expr = unbound.bind(struct);
Assert.assertEquals("Should change NOT_IN to alwaysTrue expression",
Expressions.alwaysTrue(), expr);
}
+
+ @Test
+ public void testStructFields() {
+ StructType structFieldType =
+ Types.StructType.of(Types.NestedField.optional(11, "float_field",
Types.FloatType.get()));
+ StructType struct = StructType.of(
+ optional(10, "struct", structFieldType)
+ );
+
+ UnboundPredicate<Float> lt = new UnboundPredicate<>(LT, ref("struct"),
1.234f);
+ try {
+ lt.bind(struct);
Review Comment:
Changed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
