pvary commented on code in PR #5037:
URL: https://github.com/apache/iceberg/pull/5037#discussion_r905927196
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -356,6 +360,81 @@ public void testListTables() {
Assertions.assertThat(catalog.tableExists(TABLE_IDENTIFIER)).isTrue();
}
+ private void testRegister(TableIdentifier identifier, String
metadataVersionFiles) {
Review Comment:
If I understand correctly, the PR moves the `HiveCatalog.registerTable` to
the `BaseMetastoreCatalog` so it will be available for every `Catalog` which is
inheriting from `BaseMetastoreCatalog`. So we should have a test for testing
all of the catalogs that implement the `registerTable` that the method is
working as expected.
I understand that there are some Nessie specific test cases, but I think the
basic functionality should be available and tested for all of the catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
