findepi commented on code in PR #4945:
URL: https://github.com/apache/iceberg/pull/4945#discussion_r906182831
##########
format/spec.md:
##########
@@ -631,6 +632,30 @@ When expiring snapshots, retention policies in table and
snapshot references are
2. The snapshot is not one of the first `min-snapshots-to-keep` in the
branch (including the branch's referenced snapshot)
5. Expire any snapshot not in the set of snapshots to retain.
+#### Statistics file
+
+Statistics files are valid [Puffin files](../puffin-spec). Statistics are
informational. A reader can choose to
Review Comment:
> I can also see more than one stats file per snapshot (one in puffin format
and some in other format)
this is totally possible in the future. I just don't envision it yet.
@ajantha-bhat we recently went from having list of stat files to having a
single stat file (per @rdblue 's request)
(https://github.com/apache/iceberg/pull/5021#issuecomment-1163533152)
> Thinking of partition stats,
i must admit i was thinking about them only for some time.
this PR supposedly adds table-level stats and omits partition-related stats
for simplicity.
i don't assume we will want to store all partition stats in a single file,
but I also don't know how we will store them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
