RussellSpitzer commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r906392672
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -112,21 +123,29 @@ protected CloseableIterable<FileScanTask> doPlanFiles() {
Expression filter = shouldIgnoreResiduals() ? Expressions.alwaysTrue() :
filter();
ResidualEvaluator residuals = ResidualEvaluator.unpartitioned(filter);
- return
CloseableIterable.withNoopClose(Iterables.transform(table().snapshots(), snap
-> {
+ SnapshotEvaluator snapshotEvaluator = new SnapshotEvaluator(filter,
MANIFEST_FILE_SCHEMA.asStruct(),
+ isCaseSensitive());
+ Iterable<Snapshot> filteredSnapshots =
Iterables.filter(table().snapshots(),
+ snapshot -> snapshotEvaluator.eval(snapshot));
+
+ return
CloseableIterable.withNoopClose(Iterables.transform(filteredSnapshots, snap -> {
if (snap.manifestListLocation() != null) {
DataFile manifestListAsDataFile =
DataFiles.builder(PartitionSpec.unpartitioned())
.withInputFile(io.newInputFile(snap.manifestListLocation()))
.withRecordCount(1)
.withFormat(FileFormat.AVRO)
.build();
- return new ManifestListReadTask(io, schema(), specs, new
BaseFileScanTask(
- manifestListAsDataFile, null,
- schemaString, specString, residuals));
+ return new ManifestListReadTask(
Review Comment:
We generally don't do 1 arg a line, minor formatting nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
