kbendick commented on PR #5133: URL: https://github.com/apache/iceberg/pull/5133#issuecomment-1166156139
I have a PR, https://github.com/apache/iceberg/pull/5135, that can replace this PR and also updates the base class `RequestResponseTestBase`, to always check the serialized fields. RIght now, the base class is testing that the java object has the correctly named fields. It's just by chance that the names match up with the spec. Now it's enforced with https://github.com/apache/iceberg/pull/5135 cc @rdblue @danielcweeks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
