samredai commented on PR #91: URL: https://github.com/apache/iceberg-docs/pull/91#issuecomment-1166176516
> The Iceberg logo and text are really small compared to the links. Could that be larger? Fixed to match the font-size of the links. > The top bar still covers the first search result Looks like this is due to some more missing titles, fixed by commit [2be1565](https://github.com/apache/iceberg-docs/pull/91/commits/2be1565bc082696b78ff51391119180f4cee0abe) > The content in the bar is the correct width, but it is aligned left rather than centered Fixed! <img width="1791" alt="Screen Shot 2022-06-24 at 6 26 49 PM" src="https://user-images.githubusercontent.com/43911210/175753090-c98d20a2-54cb-45b6-8220-9eb06bcffbcb.png";> > I also still see the community section of pages, which is at the top under Project now. Do you mean "How to Release" and "How to Verify Release"? Are you saying that should be moved to a dropdown under community? Is this right?: Community (Dropdown) - Roadmap - Blogs - Talks - How to Release - How to Verify a Release Project (Dropdown) - Spec - View Spec - Terms > ..the pages under each section are ordered alphabetically rather than by what people are most interested in. That puts Evolution and Maintenance as the first topics under Tables, which is awkward. Fixing this is just a matter of setting all of the weights in the config. I'll make sure to do that before this PR is merged! > I think we should roll back to the way it was with just one scroll bar. The second active scroll bar makes it awkward because it's common to move your mouse all the way to the right, then click & drag, but that doesn't work with an extra disabled scroll bar. There might be a catch-22 here: If we want to have a single scroll bar to the right, we'll have to allow the table of contents to scroll with the page ([GraphQL schema docs](https://graphql.org/learn/schema/) as an example). I employed a bit of a hack to get this working on the site that's currently live which is basically adding a big right side margin to the content and fixing the TOC into that margin area. This creates other issues where a long TOC can't scroll if it's on a smaller screen or zoomed in. I'll look into a layout that can get us both but we might end up having to choose between: - Option A: Allow the scroll bar to be placed by the content and have a fixed TOC (which auto displays a scroll bar if the TOC is too long) - Option B: Place a single scroll bar to the right and let the TOC scroll with the content As an aside, I would have liked to keep this change outside of this PR but this logic needed to be changed to account for the left-nav in the docs site which previously didn't need to be considered when the logic was only used for the landing-page. I could also fix the left-nav into a large margin area set on the content but that doubles the issue of no scroll on smaller/zoomed screens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/43911210/175753090-c98d20a2-54cb-45b6-8220-9eb06bcffbcb.png"](https://user-images.githubusercontent.com/43911210/175753090-c98d20a2-54cb-45b6-8220-9eb06bcffbcb.png"){kind=link}