RussellSpitzer commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r906628674
##########
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -133,6 +133,43 @@ public void testRewriteDataFilesWithSortStrategy() {
assertEquals("Data after compaction should not change", expectedRecords,
actualRecords);
}
+ @Test
+ public void testRewriteDataFilesWithZOrder() {
+ createTable();
+ // create 10 files under non-partitioned table
+ insertData(10);
+ List<Object[]> expectedRecords = currentData();
+
+ // set z_order = c1,c2
+ List<Object[]> output = sql(
+ "CALL %s.system.rewrite_data_files(table => '%s', " +
+ "strategy => 'zorder', sort_order => 'c1,c2')",
Review Comment:
Strategy = sort, sort_order = zorder(c1, c2)
In the future we would want to be able to also support
Strategy = sort, sort_order = c3, zorder(c1, c2)
But that's not important at the moment. For now we only really support one
or the other. So either you have Zorder( some columns) or a comma separated
list of columns with ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
