Fokko commented on PR #5030: URL: https://github.com/apache/iceberg/pull/5030#issuecomment-1167868997
Hey @jun-he [I'm using singledispatch over singledispatchmethod]: https://github.com/apache/iceberg/blob/2f550cd65cfb2c7db689774dfee5fba70099de28/python/src/iceberg/avro/reader.py#L250-L317 For the same reason as you mentioned (performance). Using singledispatch also allows you to set the types in the function signature, which is nice for static analysis. Maybe another reason to go for singledispatch over singledispatchmethod? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
