singhpk234 commented on PR #5094: URL: https://github.com/apache/iceberg/pull/5094#issuecomment-1168229622
> @singhpk234, I think this is ready to commit. What PR should we commit first? This one? I was initially thinking this could be first one to get in having just 3.3 without 3.2 and immediately we would merge a followup pr to addback a 3.2 with making 3.3 and 3.2 ci work together. > I think the idea is to rebase and merge this rather than squash and merge +1, This is a good idea, if we don't squash we will be able to preserve the history. > @singhpk234, can you rebase and fix the problems and then Thanks @rdblue, have rebased the changes, here is the updated gist post rebase : https://gist.github.com/singhpk234/640953c2658a6b16fa94c60c8066c4c0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
