Fokko commented on code in PR #5116:
URL: https://github.com/apache/iceberg/pull/5116#discussion_r908050732
##########
python/src/iceberg/avro/reader.py:
##########
@@ -177,13 +222,28 @@ def read(self, decoder: BinaryDecoder) -> Any | None:
return self.option.read(decoder)
return None
+ def skip(self, decoder: BinaryDecoder) -> None:
+ if decoder.read_int() > 0:
+ return self.option.skip(decoder)
+
@dataclass(frozen=True)
class StructReader(Reader):
- fields: tuple[Reader, ...] = dataclassfield()
+ fields: tuple[tuple[int | None, Reader], ...] = dataclassfield()
def read(self, decoder: BinaryDecoder) -> AvroStruct:
- return AvroStruct([field.read(decoder) for field in self.fields])
+ result: list[Any | StructProtocol] = [object] * len(self.fields)
Review Comment:
It is just a placeholder to pre-allocate the list. `None` works as well,
I've updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
