szehon-ho commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r908116610
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -43,6 +52,7 @@
* This table may return duplicate rows.
*/
public class AllManifestsTable extends BaseMetadataTable {
+ private static final int REF_SNAPSHOT_ID = 18;
Review Comment:
Yea I am not sure if there is consensus, Russell made a discussion in
https://github.com/apache/iceberg/pull/4847#discussion_r906391975 but didn't
finished (not sure if there is a big value for the other constants if they are
never referenced outside?). But If so, we should do it in another pr as its
unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
