bryanck commented on code in PR #5143:
URL: https://github.com/apache/iceberg/pull/5143#discussion_r908577939
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -101,16 +99,14 @@ protected List<Expression> filterExpressions() {
return filterExpressions;
}
- protected abstract List<CombinedScanTask> tasks();
-
@Override
public Batch toBatch() {
- return new SparkBatch(sparkContext, table, readConf, tasks(),
expectedSchema);
+ return this;
Review Comment:
My suspicion is that there is some check that the scan implements Batch, or
some other equality check someplace, that is required for filter pushdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
