rdblue commented on code in PR #5116:
URL: https://github.com/apache/iceberg/pull/5116#discussion_r908630143
##########
python/src/iceberg/avro/reader.py:
##########
@@ -76,66 +76,102 @@ class Reader(Singleton):
def read(self, decoder: BinaryDecoder) -> Any:
...
+ @abstractmethod
+ def skip(self, decoder: BinaryDecoder) -> None:
+ ...
+
class NoneReader(Reader):
def read(self, _: BinaryDecoder) -> None:
return None
+ def skip(self, decoder: BinaryDecoder) -> None:
+ return None
+
class BooleanReader(Reader):
def read(self, decoder: BinaryDecoder) -> bool:
return decoder.read_boolean()
+ def skip(self, decoder: BinaryDecoder) -> None:
+ decoder.skip_boolean()
+
class IntegerReader(Reader):
def read(self, decoder: BinaryDecoder) -> int:
return decoder.read_int()
+ def skip(self, decoder: BinaryDecoder) -> None:
+ decoder.skip_int()
-class LongReader(Reader):
- def read(self, decoder: BinaryDecoder) -> int:
- return decoder.read_long()
+
+class LongReader(IntegerReader):
+ """Longs and ints are encoded the same way, and there is no long in
Python"""
Review Comment:
I'd probably remove it to keep things simple, but it's up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
