aokolnychyi commented on code in PR #4870: URL: https://github.com/apache/iceberg/pull/4870#discussion_r908673100
########## api/src/main/java/org/apache/iceberg/ChangelogScanTask.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +/** + * A changelog scan task. + */ +public interface ChangelogScanTask extends FileScanTask { + /** + * Returns the operation type (i.e. insert/delete). + */ + ChangelogOperation operation(); + + /** + * Returns the relative commit order in which the changes must be applied. + */ + int commitOrder(); + + /** + * Returns the snapshot ID in which the changes were committed. + */ + long commitSnapshotId(); Review Comment: This question is still open. I mainly consider 2 options to handle scans for net changes across snapshots: - Switch to `Map<String, String> commitMetadata()` that will contain things like snapshot ID and commit timestamp. That would mean having a map instead of separate columns like `_commit_snapshot_id`. It will be then easier to add more info later but it does make it harder to access what's stored in the map. - Switch to `Long` from `long` and make it null if we are scanning across snapshots. I'd be curious to hear what other folks think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
