Fokko opened a new pull request, #5151: URL: https://github.com/apache/iceberg/pull/5151
Inspired by Avro and Ryan: https://github.com/apache/iceberg/pull/5116#discussion_r907858442 <img width="1330" alt="Screenshot 2022-06-28 at 22 02 50" src="https://user-images.githubusercontent.com/1134248/176274565-bfa8e8a6-5e9e-455e-8822-cdbc1b39273e.png";> By promoting string to bytes back and forth, we can just read the string as bytes. I've added a test for Python, to make sure that the hashing functions are equal. It might be a bit overkill, but just to make sure. I don't think this is necessary for Java since it is already tested: https://github.com/apache/iceberg/blob/master/api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java#L207-L216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1134248/176274565-bfa8e8a6-5e9e-455e-8822-cdbc1b39273e.png"](https://user-images.githubusercontent.com/1134248/176274565-bfa8e8a6-5e9e-455e-8822-cdbc1b39273e.png"){kind=link}