kbendick commented on code in PR #5118:
URL: https://github.com/apache/iceberg/pull/5118#discussion_r908947788
##########
core/src/test/java/org/apache/iceberg/rest/RequestResponseTestBase.java:
##########
@@ -104,7 +103,7 @@ protected void assertRoundTripSerializesEquallyFrom(String
json, T expected) thr
T actual = deserialize(json);
assertEquals(actual, expected);
- // Check that the deserialized value serializes back into the original JSON
- Assertions.assertThat(serialize(expected)).isEqualTo(json);
+ Assert.assertEquals("The serialized version of the Java record should
match the original JSON",
+ serialize(expected), json);
Review Comment:
I updated this as the comparison of two JSON strings can be quite cumbersome
to diff using `Assertions`.
This way, the error message is much more clear about exactly what part of
the string is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
