rdblue commented on code in PR #5009:
URL: https://github.com/apache/iceberg/pull/5009#discussion_r910197381
##########
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -783,7 +783,7 @@ public void testSnapshotsTable() {
.set("summary", ImmutableMap.of(
"added-records", "1",
"added-data-files", "1",
- "changed-partition-count", "1",
+ "changed-partition-count", "0",
Review Comment:
This depends on whether we consider the root to be a partition.
I think we should leave this as-is because there isn't a compelling reason
to set this to 0 partitions, and that is a behavior change. We should suppress
the root partition summary since it is identical to the table summary, but we
shouldn't change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
