RussellSpitzer commented on code in PR #4870: URL: https://github.com/apache/iceberg/pull/4870#discussion_r910421151
########## api/src/main/java/org/apache/iceberg/DeletedRowsScanTask.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.List; + +/** + * A scan task for deleted data records generated by adding delete files to the table. + */ +public interface DeletedRowsScanTask extends ChangelogScanTask, ContentScanTask<DataFile> { Review Comment: I think a quick example in each of these java docs would be helpful. Like suggested by @rdblue above, just what is the expected output of a given task type. For example here ``` A scan task for producing records which were deleted because new delete files were added to the table. Given File A with rows (1 - 10) IN S1 with row 5 marked as deleted by a delete file D1. Given S2 with a new Delete File D2 deleting rows >= 4 DRowScanTask (S2) returns { files : (a) addedDeletes: (D2) existingDeletes: (D1) } Which should return row 4, 6, 7, 8, 9, 10 because those rows are newly marked as deleted by S2 while row 5 was already deleted by D1 in S1. ``` Or something like that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
