kbendick commented on code in PR #5162:
URL: https://github.com/apache/iceberg/pull/5162#discussion_r910469701
##########
build.gradle:
##########
@@ -149,6 +153,19 @@ subprojects {
exceptionFormat "full"
}
}
+
+ jar {
+ manifest {
+ attributes(
+ "Implementation-Title": project.name,
+ "Implementation-Version": project.version,
+ "Build-SHA": project.buildSha,
+ "Build-Timestamp": java.time.Instant.now().toString(),
+ "Build-JDK": "${System.properties['java.version']}
(${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
+ "Build-OS": "${System.properties['os.name']}
${System.properties['os.arch']} ${System.properties['os.version']}"
+ )
+ }
+ }
Review Comment:
This doesn't apply to entries in other `build.gradle` files unfortunately,
hence copying it to other `build.gradle` files.
I've tried adding it to `allProjects` but have yet to find a working place.
I've experimented with adding a task that runs before / after `Jar` tasks,
but when I tried it, it said we didn't have any `Jar` tasks. Can give it
another try as I'd love to place this in only one place and have it generally
apply everywhere.
**TLDR** - If anybody has any ideas, I'm very open to them 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
