kbendick commented on code in PR #5124:
URL: https://github.com/apache/iceberg/pull/5124#discussion_r912174719
##########
python/pyiceberg/table/metadata.py:
##########
@@ -270,7 +271,7 @@ def set_sort_orders(cls, data: Dict[str, Any]):
# This is going to be much nicer as soon as sort-order is an actual
pydantic object
# Probably we'll just create a UNSORTED_ORDER constant then
Review Comment:
Do these two lines still apply now that we have the constants and are using
`IcebergBaseModel`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
