nastra commented on code in PR #5045: URL: https://github.com/apache/iceberg/pull/5045#discussion_r912347374
########## docs/flink-connector.md: ########## @@ -35,10 +35,8 @@ To create the table in Flink SQL by using SQL syntax `CREATE TABLE test (..) WIT * `connector`: Use the constant `iceberg`. * `catalog-name`: User-specified catalog name. It's required because the connector don't have any default value. -* `catalog-type`: Default to use `hive` if don't specify any value. The optional values are: - * `hive`: The Hive metastore catalog. - * `hadoop`: The hadoop catalog. - * `custom`: The customized catalog, see [custom catalog](../custom-catalog) for more details. +* `catalog-type`: `hive` or `hadoop` for built-in catalogs (defaults to `hive`), or left unset for custom catalog implementations using `catalog-impl`. +* `catalog-impl`: The fully-qualified class name custom catalog implementation, must be set if `catalog-type` is unset. See also [custom catalog](../flink/flink-getting-started.md#custom-catalog) for more details. Review Comment: makes perfect sense, I should have actually read the sentence when copy/pasting it from flink-connector.md :) I updated the sentence there as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
