danielcweeks commented on code in PR #5207:
URL: https://github.com/apache/iceberg/pull/5207#discussion_r914268894
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputFile.java:
##########
@@ -67,6 +67,6 @@ public PositionOutputStream createOrOverwrite() {
@Override
public InputFile toInputFile() {
- return new GCSInputFile(storage(), blobId(), gcpProperties(), metrics());
+ return new GCSInputFile(storage(), blobId(), null, gcpProperties(),
metrics());
Review Comment:
Could we just use `GCSInputFile.fromLocation(...)` to avoid calling the
constructor with null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
