rdblue commented on code in PR #5199:
URL: https://github.com/apache/iceberg/pull/5199#discussion_r915281760
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -282,20 +283,77 @@ private static boolean isCreate(UpdateTableRequest
request) {
return isCreate;
}
- private static TableMetadata create(TableOperations ops, TableMetadata
start, UpdateTableRequest request) {
+ private static TableMetadata commitUpdate(Catalog catalog, TableIdentifier
ident, UpdateTableRequest request) {
+ Table table = catalog.loadTable(ident);
+ if (table instanceof BaseTable) {
+ TableOperations ops = ((BaseTable) table).operations();
+ return commit(ops, request.requirements(), request.updates());
+ } else {
+ throw new IllegalStateException("Cannot wrap catalog that does not
produce BaseTable");
+ }
+ }
+
+ private static TableMetadata commitCreate(Catalog catalog, TableIdentifier
ident, UpdateTableRequest request) {
+ // this is a hacky way to get TableOperations for an uncommitted table
+ Transaction transaction = catalog.buildTable(ident,
EMPTY_SCHEMA).createOrReplaceTransaction();
+ if (!(transaction instanceof BaseTransaction)) {
+ throw new IllegalStateException("Cannot wrap catalog that does not
produce BaseTransaction");
Review Comment:
Looks like this could be cleaner if it were rewritten to use
`Preconditions.checkState` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
