amogh-jahagirdar commented on PR #4578: URL: https://github.com/apache/iceberg/pull/4578#issuecomment-1177003865
@namrathamyske > With this PR, the breaking change is to set cleanExpiredFiles to false if the table has more than one ref. No, the operation will fail if cleanExpiredFiles is set and there are multiple retained refs. It shouldn't break the existing linear history case and should be backwards compatible but please report in case you ran into any issues! See this [comment](https://github.com/apache/iceberg/pull/4578#discussion_r863337777) . To do a correct removal of files with multiple references, a reachability analysis needs to be done which requires quite a bit more implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
