RussellSpitzer commented on code in PR #5212:
URL: https://github.com/apache/iceberg/pull/5212#discussion_r915899405
##########
core/src/main/java/org/apache/iceberg/util/ZOrderByteUtils.java:
##########
@@ -166,7 +166,8 @@ static byte[] interleaveBits(byte[][] columnsBinary, int
interleavedSize) {
* @param interleavedSize the number of bytes to use in the output
* @return the columnbytes interleaved
*/
- @SuppressWarnings("ByteBufferBackingArray")
+ // NarrowingCompoundAssignment is intended here. See
https://github.com/apache/iceberg/pull/5200#issuecomment-1176226163
Review Comment:
The only reason I don't have this documented more is that I was hoping we
can get a better implementation in :)
I think we should write in some optimized versions for 2, 3, 4 columns since
I think most cases will benefit in that range. Having more than that many Z
order dimensions is probably a waste
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
