kbendick commented on code in PR #5222:
URL: https://github.com/apache/iceberg/pull/5222#discussion_r916073184
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java:
##########
@@ -135,8 +135,7 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
io().deleteFile(newMetadataLocation);
}
} catch (RuntimeException e) {
- LOG.error("Fail to cleanup metadata file at {}", newMetadataLocation,
e);
- throw e;
+ LOG.error("Failed to cleanup metadata file at {}",
newMetadataLocation, e);
Review Comment:
I like this option as well. As we lose the `CommitFailedException`, other
than the log... but the exception is the most likely thing to be seen.
But I'd personally wait a bit to see if we hear from somebody at AWS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
