ajantha-bhat commented on code in PR #4826:
URL: https://github.com/apache/iceberg/pull/4826#discussion_r917001449
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -157,19 +161,21 @@ public TableBuilder withProperty(String key, String
value) {
return this;
}
+ protected TableMetadata newTableMetadata() {
+ String baseLocation = location != null ? location :
defaultWarehouseLocation(identifier);
Review Comment:
Because it is a user-facing API, (nothing stops the user from calling in
two places while writing custom logic around it)
I felt it looks odd to return a different result for the same input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
