Fokko commented on code in PR #5124:
URL: https://github.com/apache/iceberg/pull/5124#discussion_r918002844
##########
python/pyiceberg/table/metadata.py:
##########
@@ -92,6 +96,14 @@ def construct_refs(cls, data: Dict[str, Any]):
data["refs"] = {MAIN_BRANCH:
SnapshotRef(snapshot_id=current_snapshot_id,
snapshot_ref_type=SnapshotRefType.BRANCH)}
return data
+ def bind(self):
Review Comment:
Hey @rdblue I agree. Modifying the state might not be the best idea. It will
make it simpler for now, but probably complicate things in the long run. I've
changed it to bind them when using them and returning a new list of
sort-orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
