dimas-b commented on code in PR #5010:
URL: https://github.com/apache/iceberg/pull/5010#discussion_r918345695
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -116,6 +117,38 @@ public ThisT scanManifestsWith(ExecutorService
executorService) {
return self();
}
+ @Override
+ public ThisT toBranch(String branch) {
+ throw new UnsupportedOperationException("Performing operations on a branch
is currently not supported");
Review Comment:
Thanks for the clarification, @namrathamyske ! Would you mind updating the
message to something like `Performing [SnapshotProducer operations on a branch
is currently not supported` to avoid making a (false) impression that it is not
supported in "general"?.. or use different wording as you see fit. My only
concern is that getting the old message in one context might be interpreted
that it is not supported anywhere.
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -116,6 +117,38 @@ public ThisT scanManifestsWith(ExecutorService
executorService) {
return self();
}
+ @Override
+ public ThisT toBranch(String branch) {
+ throw new UnsupportedOperationException("Performing operations on a branch
is currently not supported");
Review Comment:
Thanks for the clarification, @namrathamyske ! Would you mind updating the
message to something like `Performing SnapshotProducer operations on a branch
is currently not supported` to avoid making a (false) impression that it is not
supported in "general"?.. or use different wording as you see fit. My only
concern is that getting the old message in one context might be interpreted
that it is not supported anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
