kbendick commented on code in PR #5259:
URL: https://github.com/apache/iceberg/pull/5259#discussion_r919255482
##########
api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java:
##########
@@ -113,15 +114,20 @@ public static <R, E1 extends Exception, E2 extends
Exception, E3 extends Excepti
try {
finallyBlock.run();
} catch (Exception e) {
- LOG.warn("Suppressing failure in finally block", e);
if (failure != null) {
+ LOG.warn("Suppressing failure in finally block", e);
Review Comment:
I moved this log because we're not suppressing `e` in the other block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
