szehon-ho commented on code in PR #4812:
URL: https://github.com/apache/iceberg/pull/4812#discussion_r919500148
##########
core/src/main/java/org/apache/iceberg/io/DeleteSchemaUtil.java:
##########
@@ -20,13 +20,38 @@
package org.apache.iceberg.io;
import org.apache.iceberg.MetadataColumns;
+import org.apache.iceberg.Partitioning;
import org.apache.iceberg.Schema;
+import org.apache.iceberg.Table;
+import org.apache.iceberg.types.TypeUtil;
import org.apache.iceberg.types.Types;
public class DeleteSchemaUtil {
private DeleteSchemaUtil() {
}
+ public static Schema metadataTableSchema(Table table) {
+ return metadataTableSchema(table, Partitioning.partitionType(table));
+ }
+
+ public static Schema metadataTableSchema(Table table, Types.StructType
partitionType) {
+ Schema result = new Schema(
+ MetadataColumns.DELETE_FILE_PATH,
Review Comment:
Actually looking into this, if I don't re-use the metadata column I have to
change a lot of codes, like:
- BaseDataReader.constantsMap will need new method to populate partition
based on new partition id, which I'll have to pass in based on what field is
selected. (Currently since both id's are the same it works)
- All the error checks for whether selected columns are in metadata columns
need to take this into account. Currently this uses
MetadataColumns.metadataFieldIds(), which will need to be now something like
MetadataColumns.metadataAndConstantFieldIds() to take into account new column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
